Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open question - handling of transactionId in case of reorg. #8

Open
apetersson opened this issue Nov 21, 2019 · 0 comments
Open

open question - handling of transactionId in case of reorg. #8

apetersson opened this issue Nov 21, 2019 · 0 comments

Comments

@apetersson
Copy link

I just browsed through the code in 5 minutes and i have a bad feeling:

confirmTransaction only takes a transactionId - and not a hash of the underlying semantics. / tx summary.

what if there is a 2-of-2 ms wallet , user A, B. A submits a harmless tx, asks B to confirm. B confirms transactionId 1. Meanwhile, user A (who might own some mining power) publishes a malicious tx also with transactionId 1, and includes it on a different branch. reorg happens now on that branch user B agrees to the malicious tx.

can this be mitigated by user B in any way? - other than waiting a certain # of confirmations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant