Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env overrides should allow individual variable overrides #1475

Open
dustinsmith1024 opened this issue Oct 9, 2024 · 0 comments
Open

Env overrides should allow individual variable overrides #1475

dustinsmith1024 opened this issue Oct 9, 2024 · 0 comments
Labels
enhancement New feature or request synthetics Related to [synthetics]

Comments

@dustinsmith1024
Copy link

Feature request description

Can we allow overriding just one environment variable?

I believe this used to work as my tests recently started failing. I tried switching to the new overrides syntax and got tripped up for awhile with support. Eventually I removed the variable and everything started working again.

https://github.com/DataDog/datadog-ci/blob/master/src/commands/synthetics/run-tests-command.ts#L330-L336

Solution

Have this not override all the other variables from the config file.

DATADOG_SYNTHETICS_OVERRIDE_VARIABLES='{\"ROUTER_URL\":\"router.app.com\"}' datadog-ci synthetics run-tests -s 'service:gateway-router' --failOnMissingTests --config ./synthetics/preview-config.json",

or maybe allow some ability to pass the env var in

DATADOG_SYNTHETICS_OVERRIDE_VARIABLES_ROUTER_URL="router.app.com" datadog-ci synthetics run-tests -s 'service:gateway-router' --failOnMissingTests --config ./synthetics/preview-config.json",

Additional context

No response

Command

synthetics

@dustinsmith1024 dustinsmith1024 added the enhancement New feature or request label Oct 9, 2024
@github-actions github-actions bot added the synthetics Related to [synthetics] label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request synthetics Related to [synthetics]
Projects
None yet
Development

No branches or pull requests

1 participant