Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make listen address for administrative API configurable. #309

Open
tobz opened this issue Nov 7, 2024 · 0 comments
Open

Make listen address for administrative API configurable. #309

tobz opened this issue Nov 7, 2024 · 0 comments
Labels
area/observability Internal observability of ADP and Saluki. effort/simple Involves trivial changes that should be fine so long as the code compiles and tests pass. good first issue Good for newcomers type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo.

Comments

@tobz
Copy link
Member

tobz commented Nov 7, 2024

Context

Right now, the administrative API is hard-coded to listen on 127.0.0.1:9999, which is more than fine for testing. In the future, though, we have to cope with the fact that there might be port conflicts that have to be worked around. We're not going to force people to change their ports, so we need to support changing the port on our side.
@tobz tobz added area/observability Internal observability of ADP and Saluki. effort/simple Involves trivial changes that should be fine so long as the code compiles and tests pass. good first issue Good for newcomers type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo. labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/observability Internal observability of ADP and Saluki. effort/simple Involves trivial changes that should be fine so long as the code compiles and tests pass. good first issue Good for newcomers type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tobz