You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 10, 2022. It is now read-only.
The issue here is pretty straight forward, on monitors that have any display scaling set (which I do, and I think it's pretty common, in the era of hdpi monitors), scrollTop can return a decimal value (see here). scrollHeight and `clientHeight on the other hand, always round to an integer (see here and here).
This results in an error where scrollTop is less than scrollDist, even though the scrollbar has reached the bottom. This is breaking preventParentScroll for me.
It's a super easy fix, and I'd be fine to do a PR if you're accepting them. Thanks!
The text was updated successfully, but these errors were encountered:
The issue here is pretty straight forward, on monitors that have any display scaling set (which I do, and I think it's pretty common, in the era of hdpi monitors),
scrollTop
can return a decimal value (see here).scrollHeight
and `clientHeight on the other hand, always round to an integer (see here and here).This results in an error where
scrollTop
is less thanscrollDist
, even though the scrollbar has reached the bottom. This is breakingpreventParentScroll
for me.It's a super easy fix, and I'd be fine to do a PR if you're accepting them. Thanks!
The text was updated successfully, but these errors were encountered: