Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Company cards] Cards collection is returned as an array #52616

Open
mountiny opened this issue Nov 15, 2024 · 2 comments
Open

[Company cards] Cards collection is returned as an array #52616

mountiny opened this issue Nov 15, 2024 · 2 comments
Assignees
@mountiny @Christinadobrzyn
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@mountiny
Copy link
Contributor

Coming from here

When no cards are assigned on a feed yet, the collection is returned as an empty object, which PHP then turns into an empty array.

We cannot merge object into an array in onyx so we need to unsure an empty object remains that way in API
@mountiny mountiny added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Nov 15, 2024
@mountiny mountiny self-assigned this Nov 15, 2024
@mountiny mountiny added the Reviewing Has a PR in review label Nov 15, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 15, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny
Copy link
Contributor Author

PR in staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mountiny mountiny

@Christinadobrzyn Christinadobrzyn

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
[#whatsnext] #expense
Status: No status
[wave-collect] Workspace Feeds
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mountiny @Christinadobrzyn