-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove testing utilities from production code #175
Comments
Move to a separate namespace that is not included in the prod uberjar. |
this is a breaking change, because some some clients might be using this function. I am fine with this, since |
but it is necessary to remove it if we dont want to force clients to depend on |
New PR #233 |
Function
docker-postgres!
defined in namespaceframework.db.core
is only being used in test namespaces, whether we look at the framework codebase, its examples or the Frankie project. I doubt that I will ever be used in any production environment and for this reason I propose that it should be removed from production code.It also invites developers to expand configuration of their projects in a manner that I personally don't consider correct.
I agree that the function is valuable for testing purposes, but if we insist on keeping and maintaining it, we should move it to a separate project which can be later used strictly as a test dependency and not to be part of a production code.
The text was updated successfully, but these errors were encountered: