Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testing utilities from production code #175

Open
petervlk opened this issue Dec 15, 2021 · 4 comments · May be fixed by #233
Open

Remove testing utilities from production code #175

petervlk opened this issue Dec 15, 2021 · 4 comments · May be fixed by #233

Comments

@petervlk
Copy link

petervlk commented Dec 15, 2021

Function docker-postgres! defined in namespace framework.db.core is only being used in test namespaces, whether we look at the framework codebase, its examples or the Frankie project. I doubt that I will ever be used in any production environment and for this reason I propose that it should be removed from production code.

It also invites developers to expand configuration of their projects in a manner that I personally don't consider correct.

I agree that the function is valuable for testing purposes, but if we insist on keeping and maintaining it, we should move it to a separate project which can be later used strictly as a test dependency and not to be part of a production code.

@soulflyer
Copy link
Contributor

Move to a separate namespace that is not included in the prod uberjar.

@petervlk
Copy link
Author

Move to a separate namespace that is not included in the prod uberjar.

this is a breaking change, because some some clients might be using this function. I am fine with this, since docker-postgres! is just destructuring xiana cinfig and simply building testcontainer docker instance. maybe we can move it into examples, so anyone who will need it can copy paste it

@petervlk
Copy link
Author

petervlk commented Jul 14, 2022

but it is necessary to remove it if we dont want to force clients to depend on testcontiners in their production artifacts.

@petervlk petervlk linked a pull request Jul 19, 2022 that will close this issue
2 tasks
@g-krisztian
Copy link
Collaborator

New PR #233

@g-krisztian g-krisztian linked a pull request Sep 21, 2022 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants