Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App migrations #1335

Open
nemchik opened this issue Jun 13, 2021 · 2 comments
Open

App migrations #1335

nemchik opened this issue Jun 13, 2021 · 2 comments
Labels
enhancement New feature or request work-in-progress Stale Exempt

Comments

@nemchik
Copy link
Member

nemchik commented Jun 13, 2021

I think we can implement a way to handle migrations when we switch images, ex: letsencrypt to swag, or oznu's cf ddns to hotio's cf ddns or hydra2 to nzbhydra2.

Right now we have some minimal stuff in https://github.com/GhostWriters/DockSTARTer/blob/master/.scripts/env_sanitize.sh but we should split anything app specific out into separate files. To keep things clean we can probably make a subfolder in the scripts folder and have one file per app matching the app name (maybe prefixed or something). We would also need a standard way to figure out if a migration is needed. Likely compare the enabled apps to the list of files in the migrations folder (loop over them and look for a match) and then run the function. The function in the migration file would determine if the app needs a migration. Possibly by checking for old env vars or file/folder locations and only taking action if needed. At the end of each migration function we should prompt the user to remove any variables or files/folders that triggered the migration function to think it needs to complete a migration.

@nemchik nemchik added the enhancement New feature or request label Jun 13, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@nemchik
Copy link
Member Author

nemchik commented Sep 12, 2021

Keep this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request work-in-progress Stale Exempt
Projects
None yet
Development

No branches or pull requests

1 participant