Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #126

Open
elfring opened this issue Nov 7, 2020 · 3 comments
Open

reserved identifier violation #126

elfring opened this issue Nov 7, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@elfring
Copy link

elfring commented Nov 7, 2020

I would like to point out that identifiers like “__initialize_egl_h__” and “__wpe_fdo_h__do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

@aperezdc aperezdc added enhancement New feature or request good first issue Good for newcomers labels Nov 30, 2020
@aperezdc
Copy link
Member

While this is not a pressing issue, I agree that we should avoid using reserved identifiers with leading underscores where possible and it would be a good cleanup to do at some point.

@aperezdc
Copy link
Member

In the case of headers, it would be even better to replace the guards with #pragma once and avoid the issue of needing identifiers for the guards altogether.

@elfring
Copy link
Author

elfring commented Nov 30, 2020

How do you think about to achieve standard compliance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants