Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/remove of nonexistent doc shouldn't add an item to transaction #82

Open
mattmccutchen opened this issue Feb 11, 2017 · 0 comments

Comments

@mattmccutchen
Copy link
Collaborator

If update is called with the ID of a document that doesn't exist, it logs a message but goes on and adds an item for the nonexistent document to the transaction anyway, which might have unexpected consequences later. I'm guessing remove does the same thing, but I haven't tested it. I'd expect these operations not to add an item.

(#80 would subsume this issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant