-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility issue: Ultimate Dashboard PRO (infinite loop issue) #133
Comments
Hi @HighLiuk I'm on holiday untill half july so won't be able to check this. Keep in mind that even if I fix the error on my end there is a possibility that this won't make the plugin compatible. In any case, I'm not familiar with the plugin and since its a pro version I have no way to debug this. Are you able to setup a dev environment for me to check once I'm back? Cheers, Jory |
Hey @JoryHogeveen thank you for the reply.
Sure, nevertheless let's try.
I'll do my best. Let me think for a way to reproduce this without the PRO version since I guess there's a way. Let's see. |
Ok @JoryHogeveen I can confirm this issue has nothing to do with UDB PRO but is a pure VAA issue. Steps to reproduce:
The mu plugin: add_action('plugins_loaded', function() {
get_blog_option( 1, 'test_option', [] );
}); Note: adding the code as a regular plugin which is network active makes no difference - the bug is still present. UDB PRO triggers the bug since it needs to check some options on a "blueprint" site. But this makes, in general, any plugin that uses How about this @JoryHogeveen? I guess now you have all the data you need to debug this. Thank you in advance 🙏🏻 |
Hi @HighLiuk Thank you so much for your research! This will definitely help me with creating a patch release. From first glance it seems that the I will dive into this once I'm back from my travels. Do you have a short-term solution in the meantime? Cheers, Jory |
Hey @JoryHogeveen thank you for your reply! |
@JoryHogeveen hey there. Any news on this? |
@JoryHogeveen ping |
Hi @HighLiuk I re-read the logs and I think I understand what is happening. Because you've set a blueprint site it will keep trying to get the capabilities from the blueprint site by switching to it. In turn this will cause my plugin to reload. This will trigger a loop. I've mace a prove-of-concept patch for you to test (since I do not have the Pro version). Let me know if this patch fixes your issue and if it still functions correct. |
God bless you @JoryHogeveen it finally works! 🙏🏻 |
Hi @HighLiuk |
What do you mean with that? I can confirm it does not enter the loop
anymore when the fix is applied
Il ven 18 ott 2024, 13:17 Jory Hogeveen ***@***.***> ha
scritto:
… Hi @HighLiuk <https://github.com/HighLiuk>
Good to hear! Perfect. And the switching functionality form this plugins
is also still working well?
—
Reply to this email directly, view it on GitHub
<#133 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APQBPL4JYSQFYXKQ7F5FPRTZ4DU4PAVCNFSM6AAAAABJUE7U6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRSGIZTCNBXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
What I mean is that I'd like to verify that switching users or roles is still working after this patch. |
I tried switching users, roles, capabilities. Also, I manage a multi site
installation and it looks like there is no problem switching cross-site
users as well
Il ven 18 ott 2024, 13:30 Jory Hogeveen ***@***.***> ha
scritto:
… What I mean is that I'd like to verify that switching users or roles is
still working after this patch.
My guess is the chance is little that this would break functionality but
better safe than sorry :)
—
Reply to this email directly, view it on GitHub
<#133 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APQBPL6PMTLQTG6XJ6CILXTZ4DWMHAVCNFSM6AAAAABJUE7U6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRSGI2TINZTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Describe the bug
The plugin is not compatible with Ultimate Dashboard PRO.
Under some circumstances, it goes to an infinite loop.
error.log
Steps to reproduce the behavior:
Expected behavior
I expect not to see fatal errors caused by infinite loops
Screenshots
https://idearia.link/i/AX6yma
Specifications
Additional context
To me, it looks like a "switch_to_blog" problem. I guess this is not Ultimate Dashboard PRO's fault since the infinite loop happens within View Admin As functions & hooks.
The text was updated successfully, but these errors were encountered: