-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release broke DifferentiationInterface #290
Comments
I think that is actually a bug in Diffractor introduced by this change, unintentionally. The API remains the same, that code should still work and it looks like it does (until it hits this bug in map) |
Sounds good! I think DifferentiationInterface might have accidentally become PkgEval for AD ^^ |
Actually the problem is already in v0.2.7, but not in v0.2.6 |
Hey @oxinabox, friendly ping on this one. At the moment I need to freeze the Diffractor version in the DifferentiationInterface compat bounds, which might prevent people from testing your latest improvements |
Bumping this one since it makes Diffractor unusable with DifferentiationInterface, see for instance JuliaDiff/DifferentiationInterface.jl#324 |
sorry this has been sitting on my todo for ages. I will try and take a look tomorrow or monday |
No rush at all. I just thought it could be nice for the Tapir people who want to try Diffractor over Tapir. DI makes it significantly easier, but there's no time pressure so don't stress 😊 |
Since the CI logs expired, here's a copypaste from a recent one: MethodError: no method matching (Diffractor.FwdMap{false, E, T} where {E, T<:(Diffractor.AbstractTangentBundle{false})})(::Diffractor.TangentBundle{1, typeof(sin), Diffractor.TaylorTangent{Tuple{NoTangent}}})
Stacktrace:
[1] (::Diffractor.∂☆{1, false})(zc::Diffractor.TangentBundle{1, typeof(copy), Diffractor.UniformTangent{NoTangent}}, bc::Diffractor.TangentBundle{1, Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{2}, Tuple{Base.OneTo{Int64}, Base.OneTo{Int64}}, typeof(sin), Tuple{Matrix{Float64}}}, Diffractor.TaylorTangent{Tuple{Tangent{Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{2}, Tuple{Base.OneTo{Int64}, Base.OneTo{Int64}}, typeof(sin), Tuple{Matrix{Float64}}}, @NamedTuple{style::NoTangent, f::NoTangent, args::Tangent{Tuple{Matrix{Float64}}, Tuple{Matrix{Float64}}}, axes::NoTangent}}}}})
@ ~/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterfaceTest/src/test_differentiation.jl:114 [inlined]
[27] macro expansion
@ /opt/hostedtoolcache/julia/1.10.6/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:1669 [inlined]
[28] macro expansion
@ ~/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterfaceTest/src/test_differentiation.jl:112 [inlined]
[29] macro expansion
@ /opt/hostedtoolcache/julia/1.10.6/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:1669 [inlined]
[30] macro expansion
@ ~/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterfaceTest/src/test_differentiation.jl:109 [inlined]
[31] macro expansion
@ /opt/hostedtoolcache/julia/1.10.6/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
[32] test_differentiation(backends::Vector{AutoDiffractor}, scenarios::Vector{Scenario}; correctness::Bool, type_stability::Symbol, allocations::Symbol, benchmark::Symbol, excluded::Vector{Symbol}, detailed::Bool, logging::Bool, isapprox::Function, atol::Int64, rtol::Float64, scenario_intact::Bool, sparsity::Bool, ignored_modules::Nothing, function_filter::DifferentiationInterfaceTest.var"#620#627", skip_allocations::Bool, count_calls::Bool, benchmark_test::Bool)
@ DifferentiationInterfaceTest ~/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterfaceTest/src/test_differentiation.jl:109
[33] test_differentiation
@ ~/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterfaceTest/src/test_differentiation.jl:83 [inlined]
[34] #test_differentiation#628
@ ~/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterfaceTest/src/test_differentiation.jl:196 [inlined]
[35] top-level scope
@ ~/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterface/test/Back/ChainRulesBackends/diffractor.jl:13
[36] include(fname::String)
@ Base.MainInclude ./client.jl:494
[37] macro expansion
@ ~/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterface/test/runtests.jl:49 [inlined]
[38] macro expansion
@ /opt/hostedtoolcache/julia/1.10.6/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:1669 [inlined]
[39] macro expansion
@ ~/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterface/test/runtests.jl:44 [inlined]
[40] macro expansion
@ /opt/hostedtoolcache/julia/1.10.6/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
[41] macro expansion
@ ~/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterface/test/runtests.jl:44 [inlined]
[42] macro expansion
@ /opt/hostedtoolcache/julia/1.10.6/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
[43] macro expansion
@ ~/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterface/test/runtests.jl:43 [inlined]
[44] macro expansion
@ /opt/hostedtoolcache/julia/1.10.6/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
[45] top-level scope
@ ~/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterface/test/runtests.jl:26
[46] include(fname::String)
@ Base.MainInclude ./client.jl:494
[47] top-level scope
@ none:6
[48] eval
@ ./boot.jl:385 [inlined]
[49] exec_options(opts::Base.JLOptions)
@ Base ./client.jl:296
[50] _start() |
See this CI log:
https://github.com/gdalle/DifferentiationInterface.jl/actions/runs/8617680672/job/23618201628?pr=165
Do you have a suggestion on how to modify these lines?
https://github.com/gdalle/DifferentiationInterface.jl/blob/11233ce8e2eda5912da39b47d2e3c6afa46d362e/DifferentiationInterface/ext/DifferentiationInterfaceDiffractorExt/DifferentiationInterfaceDiffractorExt.jl#L14-L27
The text was updated successfully, but these errors were encountered: