Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate CORE-MATH implementations into openlibm #260

Open
ViralBShah opened this issue May 18, 2022 · 6 comments
Open

Integrate CORE-MATH implementations into openlibm #260

ViralBShah opened this issue May 18, 2022 · 6 comments

Comments

@ViralBShah
Copy link
Member

ViralBShah commented May 18, 2022

Discussed in: #212 (comment)

CORE-MATH: https://gitlab.inria.fr/core-math/core-math
Comparison with OpenLibm: https://sympa.inria.fr/sympa/arc/core-math/2022-03/msg00011.html

@zimmermann6
Copy link

The following reference might be relevant : https://hal.inria.fr/hal-03721525. The CORE-MATH developers are ready to help with any issue found during this integration.

@ViralBShah
Copy link
Member Author

Does CORE-MATH provide a testsuite? My concern is that this requires a fair bit of surgery (since CORE-MATH is not a full libm replacement) and needs incorporation. A complete libm testsuite would give a lot more confidence.

The other major thing is that we need someone to lead this effort as well with contributions. I haven't got my mind around how to get this done.

@JeffreySarnoff
Copy link
Member

lean on me

@zimmermann6
Copy link

yes CORE-MATH provides a testsuite. For each function, say cbrt, you can do ./check.sh cbrt which will check all worst cases for all four rounding modes. For a few functions, you can also do ./check.sh --special cbrt, which will check special cases (for cbrt exact and midpoint cases).

@zimmermann6
Copy link

zimmermann6 commented Oct 11, 2022 via email

@ViralBShah
Copy link
Member Author

I would love to see this happen, but the core-math codebase is not something I am able to easily build or understand for integrating (in the little time I spent looking at it). Would be great if someone more familiar wants to start off with a couple of functions and see how this goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants