-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate CORE-MATH implementations into openlibm #260
Comments
The following reference might be relevant : https://hal.inria.fr/hal-03721525. The CORE-MATH developers are ready to help with any issue found during this integration. |
Does CORE-MATH provide a testsuite? My concern is that this requires a fair bit of surgery (since CORE-MATH is not a full libm replacement) and needs incorporation. A complete libm testsuite would give a lot more confidence. The other major thing is that we need someone to lead this effort as well with contributions. I haven't got my mind around how to get this done. |
lean on me |
yes CORE-MATH provides a testsuite. For each function, say cbrt, you can do |
Hi Viral,
yes CORE-MATH does provide a testsuite.
For univariate single precision functions, all possible inputs (about 2^32)
are checked for correct rounding against MPFR, for all 4 rounding modes:
$ ./check.sh --exhaustive exp10f
Running exhaustive check in --rndn mode...
...
For larger precision or bivariate functions, some tests are done for
hard-to-round cases, still against MPFR and for all 4 rounding modes:
$ ./check.sh exp
Running worst cases check in --rndn mode...
68059 tests passed, 0 failure(s)
Running worst cases check in --rndz mode...
68059 tests passed, 0 failure(s)
Running worst cases check in --rndu mode...
68059 tests passed, 0 failure(s)
Running worst cases check in --rndd mode...
68059 tests passed, 0 failure(s)
Best regards,
Paul
… Date: Fri, 02 Sep 2022 05:58:38 -0700
From: "Viral B. Shah" ***@***.***>
Cc: zimmermann6 ***@***.***>,
Comment ***@***.***>
[1:text/plain Show]
[2:text/html Hide Save:noname (2kB)]
Does CORE-MATH provide a testsuite? My concern is that this requires a fair
bit of surgery (since CORE-MATH is not a full libm replacement) and needs
incorporation. A complete libm testsuite would give a lot more confidence.
The other major thing is that we need someone to lead this effort as well
with contributions. I haven't got my mind around how to get this done.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.
|
I would love to see this happen, but the core-math codebase is not something I am able to easily build or understand for integrating (in the little time I spent looking at it). Would be great if someone more familiar wants to start off with a couple of functions and see how this goes. |
Discussed in: #212 (comment)
CORE-MATH: https://gitlab.inria.fr/core-math/core-math
Comparison with OpenLibm: https://sympa.inria.fr/sympa/arc/core-math/2022-03/msg00011.html
The text was updated successfully, but these errors were encountered: