Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better document valid/invalid json manifests #1203

Open
charles-lunarg opened this issue May 25, 2023 · 0 comments · May be fixed by #1273
Open

Better document valid/invalid json manifests #1203

charles-lunarg opened this issue May 25, 2023 · 0 comments · May be fixed by #1273
Labels
enhancement New feature or request

Comments

@charles-lunarg
Copy link
Collaborator

**What enhancement are you suggesting for the Vulkan Loader? Please describe in detail. **
Recently, an issue was reported that came from the Shader Object Extension Implementation Layer using a raw number instead of a string in its manifest. The loader expects a string, and the examples in the docs use strings. Yet this isn't obvious to the reader since it isn't clearly defined.

There are two solutions, one is to document the exact json types the loader expects in every field, and the second is to create a proper JSON Schema that can be used programatically.

@charles-lunarg charles-lunarg added the enhancement New feature or request label May 25, 2023
@charles-lunarg charles-lunarg linked a pull request Aug 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant