Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /candidate-urls-api endpoint to add include patterns above exclude patterns in URLs list #1042

Open
Kirandawadi opened this issue Sep 28, 2024 · 0 comments · May be fixed by #1044
Open
Assignees

Comments

@Kirandawadi
Copy link
Collaborator

Description

Fix /candidate-urls-api endpoint to add include patterns on the top of exclude patterns before returning the URLs list. Currently, the response only contains URLs list excluding those URLs matched by exclude_patterns.

Implementation Considerations

Fix with_exclusion_status() function on models/candidate_url.py to also accomodate inclusion status

Deliverable

The URLs list returned by the endpoint should be matched by excluded_patterns at first with include_patterns on the top.

Dependencies

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant