Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageInfo::queryOutputs should not trip up on placeholders #11885

Open
Ericson2314 opened this issue Nov 14, 2024 · 0 comments
Open

PackageInfo::queryOutputs should not trip up on placeholders #11885

Ericson2314 opened this issue Nov 14, 2024 · 0 comments
Labels
feature Feature request or proposal

Comments

@Ericson2314
Copy link
Member

Ericson2314 commented Nov 14, 2024

Is your feature request related to a problem? Please describe.

Currently when we try to get outputs (based on a bool parameter which perhaps we can get rid of with this), we get:

 error: derivation 'caDependingOnCA' does not have valid outputs:
 error: while evaluating the output path of a derivation at <nix/derivation-internal.nix>:19:9:

   18|       value = commonAttrs // {
   19|         outPath = builtins.getAttr outputName strict;\n
     |         ^
   20|         drvPath = strict.drvPath;
error: path '/0rmq7bvk2raajd310spvd416f2jajrabcg6ar706gjbd6b8nmvks' is not in the Nix store

or so.

This is because that is a placeholder, not a read store path.

Describe the solution you'd like

We should first check if it is a placeholder, and then the path to be std::nullopt accordingly.

Describe alternatives you've considered

Arguably this whole function is a misguided mess considering #6507 though.

Additional context

Currently breaking NixOS/hydra#1421

CC @Mic92

Priorities

Add 👍 to issues you find important.

@Ericson2314 Ericson2314 added the feature Feature request or proposal label Nov 14, 2024
Ericson2314 added a commit to Ericson2314/nix-eval-jobs that referenced this issue Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request or proposal
Projects
None yet
Development

No branches or pull requests

1 participant