adduser: command not found

[JoelLinn]

With FIRST_USER_NAME being set, /bin/bash: line 2: adduser: command not found is raised here

pi-gen/stage1/01-sys-tweaks/00-run.sh

Lines 8 to 10 in d966897

	if ! id -u ${FIRST_USER_NAME} >/dev/null 2>&1; then
	adduser --disabled-password --gecos "" ${FIRST_USER_NAME}
	fi

because /usr/sbin is not in PATH.
Possible fix is to add export PATH=$PATH:/usr/sbin inside the branch.

[JoelLinn]

I suspect this might be because /usr/sbin is not in PATH on Arch Linux, maybe there should be a global check added or the PATH overwritten on chroot.

[XECDesign]

Isn't that a configuration issues with the host OS then?

https://man.archlinux.org/man/file-hierarchy.7#COMPATIBILITY_SYMLINKS

[JoelLinn]

Isn't that a configuration issues with the host OS then?

No since one can theoretically craft a Unix/Posix OS which has its binaries in /beehive or whatever, but if the corresponding PATH is not overwritten when chrooting, it will fail the pi-gen build.

https://man.archlinux.org/man/file-hierarchy.7#COMPATIBILITY_SYMLINKS

Even if that symlink may exists, it may not be in path by default on the host

[XECDesign]

Oh right, yeah that makes sense. I didn't realise chroot inherited the host's PATH variable. I wouldn't be against a PR that sets PATH to something sensible when entering the chroot environment