Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance discrepancy between local runs and hugging face demo #115

Open
vietpho opened this issue May 2, 2024 · 1 comment
Open

Performance discrepancy between local runs and hugging face demo #115

vietpho opened this issue May 2, 2024 · 1 comment

Comments

@vietpho
Copy link

vietpho commented May 2, 2024

Hello, first of all, thank you for sharing your amazing work. However, I've noticed a difference in the results between the Hugging Face demo and running the demo.py code from the cloned GitHub repository. Even when using the same images, the performance on the Hugging Face demo appears to be much better. Could you possibly share the config settings used for the Hugging Face demo?

One change I made was to disable augmentation; I set it to accept the original image sizes directly. This adjustment improved the performance of demo.py slightly, though it still doesn't match the Hugging Face demo. It seems all the pretrained models you provided perform differently compared to HF.

I'm quite frustrated because the performance locally doesn't match the impressive results of the Hugging Face demo. I haven't modified your code except for the later tweak with the augmentation. I'm wondering if you might know why there is such a significant performance difference with the same images on the Hugging Face demo. Thanks!

@praeclarumjj3
Copy link
Member

praeclarumjj3 commented May 2, 2024

Hi @vietpho, Could you share the task you are testing and your results? The HF demo code is the same as the GitHub demo code. I don't remember making any changes.

This could be due to the difference between the package version on HF and the local runs. I remember having difficulties setting up the environment, as suggested in this repo on HF, so I had to change a few package versions. You can find the exact setup details from the files below:

https://huggingface.co/spaces/shi-labs/OneFormer/blob/main/requirements.txt
https://huggingface.co/spaces/shi-labs/OneFormer/blob/main/Dockerfile

Btw, the augmentation is happening in the HF demo as well.
https://huggingface.co/spaces/shi-labs/OneFormer/blob/main/demo/defaults.py#L70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants