Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help understanding release cycle for package #1755

Closed
KevinGrandon opened this issue Nov 12, 2024 · 2 comments
Closed

Help understanding release cycle for package #1755

KevinGrandon opened this issue Nov 12, 2024 · 2 comments

Comments

@KevinGrandon
Copy link
Contributor

Hello,

I submitted and got this PR landed on Oct 7th: #1597

On Oct 29th, this was released: https://github.com/Shopify/shopify-app-js/releases/tag/%40shopify%2Fshopify-app-remix%403.4.0

I don't see my changes listed in the release, or having been published to NPM. Just wondering if I'm missing something in the pull request, or if there's some way to get that released. Thanks!

@lizkenyon
Copy link
Contributor

lizkenyon commented Nov 12, 2024

Hi there @KevinGrandon

Before releasing during our testing we discovered your PR did not resolved the issue. So unfortunately we had to revert the PR.

It appears as though the rollup plugin does not properly handle dependencies.

We would review another PR if you are able to get this working. :)

@KevinGrandon
Copy link
Contributor Author

Understood, thank you for the reply! If I get time in the next few days I'll try to pick this up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants