Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue in the definition of testResizeToRangeWithDynamicSpatialShape, core/preprocessor_test.py(P1) #39

Open
DLPerf opened this issue Aug 27, 2021 · 1 comment

Comments

@DLPerf
Copy link

DLPerf commented Aug 27, 2021

Hello, I found a performance issue in the definition of testResizeToRangeWithDynamicSpatialShape, core/preprocessor_test.py, tf.shape(out_image) will be created repeatedly during program execution, resulting in reduced efficiency. I think out_image_shape and in_image should be created before the loop.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@ShreyAmbesh
Copy link
Owner

ShreyAmbesh commented Oct 4, 2021

Thanks for looking into it.
I am a bit busy to look into this right now
also thes files you mentions in this as well as #38 are files from TF and unchanged. It's just very old at this time.
but will be great if you can create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants