-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize image size: remove doc/tutor/etc? #20
Comments
Hmm, yeah. A flag like The potential size is higher if you consider multiple builds of the same Vim version. Like having multiple builds for Python 2 and Python 3 would mean that there's 2n builds, or 3n if you want to include a build without Python. Maybe a further optimization would be for the same Vim version to share the shared directory. Instead of |
Good idea. What's your opinion on which to remove? |
Oh sorry, yes. Those look fine to me. |
I had some thoughts after scanning through them:
I think pruning those directories is 100% fine since I personally can't see a use for them. So, I don't think these need to be considered to address this issue. I'm mainly writing it out in case they give you an epiphany or someone in the future is searching the issues to figure out why they got pruned 🤓 |
maybe use alpine's default shell? bash 4.4 is 9mb on my mac, vs 200k for dash https://github.com/tweekmonster/vim-testbed/blob/master/scripts/run_vim.sh#L6 the |
IIRC I am using / rely on bashisms in Neomake's tests. |
This requires to install ncurses explicitly, which was installed as a dep for bash before, and Vim requires it. Ref: Vimjas#20 (comment)
#26 removes bash. |
Looking at
/vim-build/vim_*/share
there are a lot of things that could be possibly pruned:From share/vim/vim80:
Currently
vim_v8.0.0027_py0_rb0_lua0
takes 27.9 MiB, which is not that much by itself, but 6 builds will be160.0 MiB
(Apparent size: 137.0 MiB
) then.What about an option to the
install_vim
script to prune those (we can agree on)?The text was updated successfully, but these errors were encountered: