Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The resulting JAVA_HOME_..._architecture variable name is inconsistent: ARM64 or AARCH64 #561

Open
3 of 5 tasks
vlsi opened this issue Nov 27, 2023 · 4 comments
Open
3 of 5 tasks
Assignees
Labels
bug Something isn't working

Comments

@vlsi
Copy link

vlsi commented Nov 27, 2023

Description:

The environment variable name is inconsistent: sometimes it is JAVA_HOME_17_AARCH64 and sometimes it is JAVA_HOME_17_ARM64.

`JAVA_HOME_${majorVersion}_${this.architecture.toUpperCase()}`,

Task version:

'actions/setup-java@v3' (SHA:0ab4596768b603586c0de567f2430c30f5b0d2b0)

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:
A description with steps to reproduce the issue. If your have a public example or repo to share, please provide the link.

Expected behavior:

The variable name should be consistent.
Preferably, the variable name should use the same values as the action's architecture input parameter:

- `architecture`: The target architecture of the package. Possible values: `x86`, `x64`, `armv7`, `aarch64`, `ppc64le`. Default value: Derived from the runner machine.

Actual behavior:

If user omits architecture, then setup-java generates JAVA_HOME_17_ARM64 environment variable.
If user passes architecture: aarch64, then setup-java generates JAVA_HOME_17_AARCH64 variable.

@marko-zivic-93
Copy link
Contributor

Hello @vlsi
Thank you for filing your issue. We will investigate it and come back to you as soon as we have some information.

@mahabaleshwars
Copy link
Contributor

Hello @vlsi,
The architecture variable defaults to the runner image's architecture when not provided, and it uses the architecture variable provided by the user accordingly. We believe this is the expected behavior. Additionally, there might be confusion if a different value is printed when the user specifies the architecture variable. Could you please let us know if this is causing any issues while running the workflows?

@mahabaleshwars
Copy link
Contributor

Hello @vlsi, can you confirm if the above feedback resolves the issue? If not, could you share the issues you are facing?

@mahabaleshwars
Copy link
Contributor

Hello @vlsi, just a friendly reminder to confirm if the above feedback resolves the issue. If not, could you please share any issues you are still facing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants