Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip cache always uses node process architecture, ignoring architecture key #971

Open
5 tasks done
alex opened this issue Oct 26, 2024 · 1 comment
Open
5 tasks done

pip cache always uses node process architecture, ignoring architecture key #971

alex opened this issue Oct 26, 2024 · 1 comment
Labels
feature request New feature or request to improve the current logic

Comments

@alex
Copy link

alex commented Oct 26, 2024

Description:

The pip caching code uses a cache key that does not include the Python binary's architecture. This leads to cache thrashing.

https://github.com/actions/setup-python/blob/main/src/cache-distributions/pip-cache.ts#L68-L75

These keys should include the Python binary architecture, which is specified with the architecture input to the action.

Action version:
5.2.0

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:
All
@alex alex added bug Something isn't working needs triage labels Oct 26, 2024
@priya-kinthali priya-kinthali added feature request New feature or request to improve the current logic and removed bug Something isn't working needs triage labels Oct 28, 2024
@priya-kinthali
Copy link
Contributor

Hello @alex 👋,
Thank you for this feature request. We will investigate it and get back to you as soon as we have some feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex @priya-kinthali