You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I found a performance issue in the definition of interpn, neurite/tf/utils/utils.py, tf.reshape will be calculated repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.
Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.
The text was updated successfully, but these errors were encountered:
Have you tested how much of a difference it makes? The for loop is only over the corners (so 4 element in 2D and 8 elements in 3D) and reshaping is a quick operation so my intuition would be that it doesnt hurt the performance, but perhaps you saw otherwise?
Hello, I found a performance issue in the definition of
interpn
, neurite/tf/utils/utils.py,tf.reshape
will be calculated repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.
The text was updated successfully, but these errors were encountered: