Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue in the definition of interpn, neurite/tf/utils/utils.py (P1) #39

Open
DLPerf opened this issue Aug 22, 2021 · 1 comment

Comments

@DLPerf
Copy link

DLPerf commented Aug 22, 2021

Hello, I found a performance issue in the definition of interpn, neurite/tf/utils/utils.py, tf.reshape will be calculated repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@adalca
Copy link
Owner

adalca commented Aug 23, 2021

@DLPerf good find, feel free to submit a PR.

Have you tested how much of a difference it makes? The for loop is only over the corners (so 4 element in 2D and 8 elements in 3D) and reshaping is a quick operation so my intuition would be that it doesnt hurt the performance, but perhaps you saw otherwise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants