Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BIT option support for BITCOUNT command #2006

Closed
1 of 2 tasks
Tracked by #1942
jihuayu opened this issue Jan 12, 2024 · 4 comments · Fixed by #2087
Closed
1 of 2 tasks
Tracked by #1942

Add BIT option support for BITCOUNT command #2006

jihuayu opened this issue Jan 12, 2024 · 4 comments · Fixed by #2087
Assignees
@kay011
Labels
enhancement type enhancement

Comments

@jihuayu
Copy link
Member

jihuayu commented Jan 12, 2024 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

I found that the BITCOUNT command doesn't have the BIT option supported. Source

Solution

Add BIT option support for BITCOUNT command.

relate issues: #1212

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@jihuayu jihuayu added the enhancement type enhancement label Jan 12, 2024
@jihuayu
Copy link
Member Author

jihuayu commented Jan 12, 2024

We can trace it by #1942.

@git-hulk git-hulk mentioned this issue Jan 12, 2024
Open
24 tasks
@git-hulk
Copy link
Member

@jihuayu Added it, thank you!

@kay011
Copy link
Contributor

kay011 commented Jan 28, 2024

Is anyone working on this? If not, you can assign it to me

@jihuayu jihuayu assigned jihuayu and kay011 and unassigned jihuayu Jan 28, 2024
@jihuayu
Copy link
Member Author

jihuayu commented Jan 28, 2024 •
edited
Loading

@kay011 Assigned. Thank you!
There are some doc you may need:

@kay011 kay011 mentioned this issue Feb 1, 2024
Merged
@PragmaTwice PragmaTwice linked a pull request Feb 1, 2024 that will close this issue
Support BIT and BYTE options in the BITCOUNT command #2087
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kay011 kay011

Labels
enhancement type enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support BIT and BYTE options in the BITCOUNT command kay011/kvrocks
3 participants
@git-hulk @jihuayu @kay011