Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load config/appsignal.rb by default #1319

Closed
7 tasks done
tombruijn opened this issue Oct 21, 2024 · 2 comments
Closed
7 tasks done

Load config/appsignal.rb by default #1319

tombruijn opened this issue Oct 21, 2024 · 2 comments
Assignees

Comments

@tombruijn
Copy link
Member

tombruijn commented Oct 21, 2024

To do

  • Load config/appsignal.rb if present on Appsignal.start.
    • I don't think we should add this logic to the Config class itself, but lib/appsignal.rb instead on start.
    • It should also not be loaded if an app calls Appsignal.configure somewhere in the app, like a Rails initializer.
  • Ignore the config/appsignal.yml YAML file if the .rb variant is present.
  • Load the config/appsignal.rb file automatically in the diagnose CLI. Hopefully it would only be necessary to add test for it.
  • Make sure it works well in combination with Appsignal.configure being called in a Rails initializer. It will either listen to Appsignal.configure or load the config/appsignal.rb file.
  • Add config option to the installer for an config/appsignal.rb file.
    • Add default config that sort of mimics the YAML file, but figure out the best way to disable for the test env etc.
  • Make the config option for the .rb the recommended option in the installer.
@tombruijn tombruijn self-assigned this Oct 21, 2024
@tombruijn
Copy link
Member Author

PR in #1324

@tombruijn
Copy link
Member Author

PR for the installer in #1327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant