AWS Exposed VPC endpoints plugin doesn't properly detect private subnets

[faridnsh]

On my environment VPC endpoints are placed in private subnets where transit gateway is used to route to VPCs and "Exposed VPC endpoints" plugin doesn't recognise the subnets as private subnets even though it doesn't have an internet gateway attached.

I believe the issue is in this utility function:

cloudsploit/helpers/aws/functions.js

Line 947 in cab05b5

routeTable.Routes.every(route => route.GatewayId && !route.GatewayId.startsWith('igw-'))) privateRouteTables.push(routeTable.RouteTableId);

It requires every route to have a "GatewayId" for it to a private subnet however, the routes can point to a NatGateway or TransitGateway and still be private.

The code should be something like this instead:

if (routeTable.RouteTableId && routeTable.Routes && !routeTable.Routes.some(route => route.GatewayId && route.GatewayId.startsWith('igw-')) privateRouteTables.push(routeTable.RouteTableId);