Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excess error logs upon termination #7264

Open
hhamalai opened this issue Oct 22, 2024 · 1 comment
Open

Excess error logs upon termination #7264

hhamalai opened this issue Oct 22, 2024 · 1 comment
Labels
bug Something isn't working needs-triage Issues that need to be triaged

Comments

@hhamalai
Copy link

Description

Observed Behavior:
Occasionally Karpenter will print logs with log.level error during shutdown due to context cancellation, e.g.,

getting messages from queue, receiving sqs messages, RequestCanceled: request context canceled
caused by: context canceled

Expected Behavior:

Normal operations should not produce error logs. On the other hand, there might be issues where the context is cancelled due to network timeouts, so simply omitting errors here is not a likely option.

Reproduction Steps (Please include YAML):

Versions:

  • Chart Version: 0.36.1

  • Kubernetes Version (kubectl version): v1.30.1

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@hhamalai hhamalai added bug Something isn't working needs-triage Issues that need to be triaged labels Oct 22, 2024
@njtran
Copy link
Contributor

njtran commented Oct 28, 2024

It makes sense to me that we would emit this log on shutdown. What logs are you trying to not emit that are being emitted? Is it just the shutdown logs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Issues that need to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants