Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow strong_rec_thresh = 0 for only importing perfect 100% matches #5458

Open
giorgiga opened this issue Oct 13, 2024 · 0 comments
Open

Allow strong_rec_thresh = 0 for only importing perfect 100% matches #5458

giorgiga opened this issue Oct 13, 2024 · 0 comments

Comments

@giorgiga
Copy link

giorgiga commented Oct 13, 2024

While a working on my already curated library, I set strong_rec_thresh = 0 and run beet im -q to only import 100% perfect albums (so that I can then look at the rest), but it seems that acts as if -t was specified.

I didn't look at the code, but I guess there's something match_accuracy < strong_rec_thresh?

If that's the case, then IMHO it should check with <= (if one says "the threshold for strong recommendations is 5%", i expect 95% matches and up to be strong recommendations). In case you are concerned about the backwards-compatibility of such change, then handling strong_rec_thresh = 0 would IMHO still be worth it.

BTW: if anyone stumbles upon here because they have the same issue, something like strong_rec_thresh = 0.0001 seems to be a valid workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant