New Check: V2 schema.Resource.Create Deprecation

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.Resource.Create field is deprecated in preference of the context-aware CreateContext. The new functionality is not available in version 1 of the Terraform Plugin SDK so this check should only flag version 2 usage of Create.

New or Affected Checks(s)

• S###

Flagged Provider Code

&schema.Resource{
  // ... other configuration ...

  Create: func(d *schema.ResourceData, meta interface{}) error { /* ... */},
}

Passing Provider Code

&schema.Resource{
  // ... other configuration ...

  CreateContext: func(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostic { /* ... */},
}

References

• https://www.terraform.io/docs/extend/guides/v2-upgrade-guide.html#more-support-for-context-context
• https://www.terraform.io/docs/extend/guides/v2-upgrade-guide.html#support-for-diagnostics
• Context aware SDK with timeouts hashicorp/terraform-plugin-sdk#276
• Diagnostics Proposal hashicorp/terraform-plugin-sdk#368