Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isFileWithIDCached Enhancement Request #12

Open
davegreco opened this issue Jan 5, 2017 · 0 comments
Open

isFileWithIDCached Enhancement Request #12

davegreco opened this issue Jan 5, 2017 · 0 comments
Labels
enhancement objective-c Related to prior code base, now on the objective-c-maintenance branch

Comments

@davegreco
Copy link

This function works as advertised, to the best of it's ability to.

As it works currently it properly indicates if a file relating to the ID provided exists within the cache. However, since the ID of the file does not change with file versioning a user of this SDK is unable to determine if a specific version of this file has been cached.

I was able to verify that internally the caching mechanism is taking the version into account, when it is given a BOXFile object with a different SHA-1 hash, it will trigger the download of that already cached file resulting in the latest version of it being stored locally.

It would be useful for the isFileWithIDCached to take the SHA-1 that way you could accurately anticipate which files need to be downloaded again to have their current versions available locally.

@PJSimon PJSimon added the objective-c Related to prior code base, now on the objective-c-maintenance branch label Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement objective-c Related to prior code base, now on the objective-c-maintenance branch
Projects
None yet
Development

No branches or pull requests

2 participants