Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay session delivery to "after the response is sent" #513

Open
lezhnev74 opened this issue Jan 4, 2023 · 1 comment
Open

Delay session delivery to "after the response is sent" #513

lezhnev74 opened this issue Jan 4, 2023 · 1 comment
Labels
backlog We hope to fix this feature/bug in the future needs discussion Requires internal analysis/discussion

Comments

@lezhnev74
Copy link

Currently the delivering phase of sessions (SessionTracker::deliverSessions) is built-in to the startSession function at RouteMatched event which adds unnecessary overhead to some lucky clients.

I understand that this "built-in" behaviour comes from underlying "bugsnag/bugsnag" package and I don't see a way how to change that from this package.

My point is to delay session delivery to after the response is sent. This can be done, as one example, by putting deliveryng code to app()->terminating(<call deliver sessions>) which will be invoked after the request is served.

What do you think?

@johnkiely1
Copy link
Member

Hi @lezhnev74,
Thanks for the suggestion. Seems like a reasonable approach, we will definitely give it some more thought as soon as priorities allow.

@johnkiely1 johnkiely1 added needs discussion Requires internal analysis/discussion backlog We hope to fix this feature/bug in the future labels Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future needs discussion Requires internal analysis/discussion
Projects
None yet
Development

No branches or pull requests

2 participants