Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for OXY2DEV/markview.nvim #764

Open
OXY2DEV opened this issue Aug 25, 2024 · 6 comments
Open

feat: Add support for OXY2DEV/markview.nvim #764

OXY2DEV opened this issue Aug 25, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@OXY2DEV
Copy link

OXY2DEV commented Aug 25, 2024

Is your feature request related to a problem? Please describe.
Hi, Is it possible to add colorscheme support for my plugin markview.nvim?

Describe the solution you'd like
It would be great if the colorscheme came with the highlight groups for the plugin.

You can check all the highlight groups used by the plugin here.

Describe alternatives you've considered
By default, the plugin will generate highlight groups based on the colorscheme. So, currently it looks like this.

Screenshot_2024-08-25-15-15-50-439_com termux-edit
Catppuccin frappe

Screenshot_2024-08-25-15-17-46-846_com termux-edit
Catppuccin latte

Screenshot_2024-08-25-15-18-34-970_com termux-edit
Catppuccin macchiato

Screenshot_2024-08-25-15-19-20-983_com termux-edit
Catppuccin mocha

Additional context
Not provided

@OXY2DEV OXY2DEV added the enhancement New feature or request label Aug 25, 2024
@OXY2DEV OXY2DEV changed the title feat: Add support for OXY2DEV/Markview.nvim feat: Add support for OXY2DEV/markview.nvim Aug 25, 2024
@barcell1
Copy link

barcell1 commented Oct 7, 2024

This plugin is amazing. +1 support for this

@sgoudham
Copy link
Contributor

sgoudham commented Oct 7, 2024

I believe the current maintainers of this repository are not active at the moment so this would most likely need to be PR'd in. However, I'm unsure if this should be accepted as #740 was already merged before this issue was raised.

https://github.com/MeanderingProgrammer/render-markdown.nvim seems to provide pretty much the same functionality and I'd imagine they can't both be enabled at the same time?

@barcell1
Copy link

barcell1 commented Oct 8, 2024

https://github.com/MeanderingProgrammer/render-markdown.nvim seems to provide pretty much the same functionality and I'd imagine they can't both be enabled at the same time?

markview.nvim is the king, better than render-markdown.nvim (although is a great plugin also)

@sgoudham
Copy link
Contributor

sgoudham commented Oct 8, 2024

I looked through our existing integrations list and it does look like we are okay with allowing multiple plugins that overlap in functionality / featuresets so I'd be happy to accept a PR for it.

I think it makes sense to set it false by default, however, I'm currently unsure of prior precendent on how we decide to set integrations to true or false. Maybe @vollowx or @mrtnvgr have some insights here?

@OXY2DEV
Copy link
Author

OXY2DEV commented Oct 8, 2024

Unless there is any significant change in what currently is used and the integration, there is no need to set it to true.

The plugin uses tree-sitter highlight groups so it shouldn't be too far off from what the document itself looks like.

I am a bit on a fence wether to request plugin support to other colorschemes. Since,

  1. It's more work for you, it's more work for the end-user(having to open a PR/request integration) and it's more work for me(as I will have to notify colorscheme authors when changes occur).
  2. It limits development as now I have a finite number of set groups(as I am sure nobody will like having to update the integrations constantly).
  3. Previews should retain the original highlight groups(either from the syntax files or tree-sitter). So, there shouldn't be any immediate need to manually add support.
  4. Due to hardware limitations I can't test colorscheme support(especially transparency) so, I can't make PRs for mot colorschemes.

But you guys are more smarter than me, so I will leave it in your hands.

@OXY2DEV
Copy link
Author

OXY2DEV commented Oct 8, 2024

@sgoudham Also, there has been significant changes to highlight groups. So the original comment is outdated.

markview.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants