Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Install, extend theme as Provider props not plugin constant #467

Open
simpletrontdip opened this issue Jul 18, 2021 · 0 comments
Open

Install, extend theme as Provider props not plugin constant #467

simpletrontdip opened this issue Jul 18, 2021 · 0 comments

Comments

@simpletrontdip
Copy link
Contributor

  • For multiple language apps, switching language also requires updating the theme, e.g. changing flow direction for RTL language.
  • For now, we install theme via plugin constant injection, this is hard to support the theme switching.
  • We need support installing/extending the global theme as Provider props instead
  • This also helps our tests more clear and concise
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant