Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(tetragon-rthooks): outdated command for containerd setup with NRI #2995

Open
paularah opened this issue Oct 12, 2024 · 3 comments
Open
Assignees
Labels
area/documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@paularah
Copy link
Contributor

paularah commented Oct 12, 2024

Specifically this part of the documentation needs to be updated. The tetragon-oci-hook-setup script no longer exists.

minikube ssh cat /etc/containerd/config.toml > /tmp/old-config.toml
./contrib/tetragon-rthooks/tetragon-oci-hook-setup patch-containerd-conf enable-nri --config-file=/tmp/old-config.toml --output=/tmp/new-config.toml
diff -u /tmp/old-config.toml /tmp/new-config.toml

@paularah
Copy link
Contributor Author

Do we still need to patch the config file to enable NRI?

@paularah
Copy link
Contributor Author

paularah commented Oct 12, 2024

The value for the container-runtime flag needs to be "containerd" in the "minikube with Containerd" tab

@kkourt kkourt self-assigned this Oct 24, 2024
@kkourt
Copy link
Contributor

kkourt commented Oct 25, 2024

Do we still need to patch the config file to enable NRI?

Yap, containerd 2.0 has not been release yet (2.0.0-rc6 was released yesterday it seems)

The value for the container-runtime flag needs to be "containerd" in the "minikube with Containerd" tab

Yap good catch!

@kkourt kkourt added good first issue Good for newcomers area/documentation Improvements or additions to documentation labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants