Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API documentation displays generics incorrectly #65

Open
shaedrich opened this issue Jan 31, 2024 · 1 comment
Open

API documentation displays generics incorrectly #65

shaedrich opened this issue Jan 31, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@shaedrich
Copy link

While in the API documentation, it only says Model> in the exception section of the Builder::sole() method, its source code shows, it actually has a generic: \Illuminate\Database\Eloquent\ModelNotFoundException<\Illuminate\Database\Eloquent\Model>

https://github.com/laravel/framework/blob/d65ea42dbec9137b94c2793b5fe06e75e8998764/src/Illuminate/Database/Eloquent/Builder.php#L645-L661

grafik
grafik

(Originally reported as laravel/framework#49907)

@williamdes williamdes added the bug Something isn't working label Jan 31, 2024
@williamdes
Copy link
Member

Hi @shaedrich
Thank you for taking the time to report this issue, I will keep it in mind and will try to fix it.
Contributions are very welcome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants