Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Sensors based on Activity Type #78

Open
craibo opened this issue Feb 12, 2023 · 0 comments
Open

Refactor Sensors based on Activity Type #78

craibo opened this issue Feb 12, 2023 · 0 comments
Assignees
@craibo
Labels
enhancement New feature or request

Comments

@craibo
Copy link
Owner

craibo commented Feb 12, 2023

Currently the sensors are in a loop and the activity type is not considered. Now that the sensor stats are fixed, this results in the historical stats being mixed between all activites that are recorded via Strava.

Suggested solution:

  1. Create 2 sensors per activity type
    eg. run_0, run_1, ride_0, ride_1, swim_0, swim_1, etc

  2. sensors to include

  • walk
  • run
  • ride
  • swim
  • mountain bike
  • workout
  • other
@craibo craibo added the enhancement New feature or request label Feb 12, 2023
@craibo craibo self-assigned this Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craibo craibo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@craibo