Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 delta doesn't page in Windows Terminal #1902

Open
vikhik opened this issue Nov 13, 2024 Discussed in #1387 · 2 comments
Open

🐛 delta doesn't page in Windows Terminal #1902

vikhik opened this issue Nov 13, 2024 Discussed in #1387 · 2 comments

Comments

@vikhik
Copy link

vikhik commented Nov 13, 2024

Discussed in #1387

I'm getting the something similar to #1387 on Windows 11/Powershell, even after using winget install -e jftuga.less.

But only with the common git lg alias: https://gist.github.com/johanmeiring/3002458

Repro:

  1. winget install -e jftuga.less
  2. winget install -e dandavison.delta
  3. git config --global core.pager delta
  4. git config --global interactive.diffFilter "delta --color-only"
  5. git config --global delta.navigate true
  6. git config --global merge.conflictStyle zdiff3
  7. restart shell, just in case
  8. git log --color --graph --abbrev-commit --oneline (works as expected)
  9. git lg (prints entire repo, no paging)

So it seems broken with --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset'

@vikhik
Copy link
Author

vikhik commented Nov 13, 2024

Actually - this appears to be more related to the terminal itself?

Doing git lg in the vscode terminal window works totally fine - but using either command in Windows Terminal is printing the whole log!

My bad - I was testing this on two different terminals and thinking it would be identical due to them both using Powershell.

Therfore... Delta doesn't work with Windows Terminal?

@vikhik vikhik changed the title 🐛 delta doesn't page with pretty log arguments 🐛 delta doesn't page in Windows Terminal Nov 13, 2024
@dandavison
Copy link
Owner

Hi @vikhik, I'm guessing the problem is that in your Windows Terminal, delta is not finding an executable named "less"? You could investigate by using delta's --pager flag to specify an absolute path to less (all delta flags can be set in git config also, so that would be something like git config --global delta.pager AbsolutePathToLess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants