Should the DSL objects types not include undefined
?
#1367
Closed
mikedidomizio
started this conversation in
General
Replies: 1 comment
-
I still agree with my original reasoning - so it's probably not going to change, it'll mean people either add a superfluous |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
With regards to the DSL objects, on the reference page and in the code it states:
The change was made in this PR with this description:
I agree, it's unlikely a user will use the wrong one. I was wondering though for the sake of having accurate typings why it not remain
readonly github?: GitHubDSL
? In CI the data will be populated if configured properly but for development it's helpful to be notified it's not necessarily guaranteed to have data. The current typings are misleading which defeats the purpose of typings.Beta Was this translation helpful? Give feedback.
All reactions