New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt data-attributes instead of classes for settings #175

Open

nmerget opened this issue Nov 30, 2022 · 0 comments

Milestone

Member

nmerget commented Nov 30, 2022

    I would expect `class="db-ui-regular"` to be `data-tonality="regular"` (and in the generator files accordingly), adapted by the other attributes like e.g. size (`data-size`), variant (`data-variant`), etc. This seem to have been overlooked in colors, scaling and typography as well.

Originally posted by @mfranzke in #174 (comment)

The text was updated successfully, but these errors were encountered:

nmerget changed the title I would expect class="db-ui-regular" to be data-tonality="regular" (and in the generator files accordingly), adapted by the other attributes like e.g. size (data-size), variant (data-variant), etc. This seem to have been overlooked in colors, scaling and typography as well. Use colors as "data-XXX" attribute

mfranzke changed the title ~~Use colors as "data-XXX" attribute~~ adapt data-attributes for settings

mfranzke changed the title ~~adapt data-attributes for settings~~ adapt data-attributes instead of classes for settings

nmerget mentioned this issue

refactor: changed typography to use only css-properties #174

Merged

mfranzke added this to the Guidelines 3.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment