Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable binding address with loopback as default #52

Open
knuton opened this issue Sep 19, 2022 · 0 comments
Open

Configurable binding address with loopback as default #52

knuton opened this issue Sep 19, 2022 · 0 comments

Comments

@knuton
Copy link

knuton commented Sep 19, 2022

Thanks for making this useful tool! 😊

As far as I can tell the server currently binds to all IPs, which means that its contents may be accessible from a machine on the local network, which may or may not be wanted.

Would you be open to making the binding address configurable? Ideally this would default to the loopback address (127.0.0.1), though this behaviour may be considered a breaking change for existing users.

It could work like this:

$ elm-doc-preview # server only listens on 127.0.0.1:8000
$ elm-doc-preview --address 192.178.0.100 --port 9090 # server only listens on 192.178.0.100:9090
$ elm-doc-preview --address 0.0.0.0 # server listens on all IPs on port 8000

Would you be interested in a PR? Is a breaking change acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant