Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using statement C# snippet doesn't work #11189

Open
davidwengier opened this issue Nov 9, 2024 · 5 comments
Open

using statement C# snippet doesn't work #11189

davidwengier opened this issue Nov 9, 2024 · 5 comments
Assignees
Milestone

Comments

@davidwengier
Copy link
Contributor

Reported by @AdmiralSnyder on Discord

Screen_Recording_2024-11-08_140733.mp4

I had a quick play and it seems like maybe using statement is the only snippet that doesn't work. Perhaps we should just filter it out?

@ryzngard
Copy link
Contributor

ryzngard commented Nov 12, 2024

Does the snippet itself do anything fancy? We could filter it out from roslyn and just provide our own...

Scratch that. Saw it was statement not directive. Filter out is fine with me

@davidwengier
Copy link
Contributor Author

Could also be a bug in the editor, not handling snippets with a space in them. It's the only one I could find, so suspicious its the only one that doesn't work

@phil-allen-msft
Copy link
Contributor

Let's filter out for now.

@ryzngard ryzngard added this to the 17.13 P2 milestone Nov 13, 2024
@ryzngard
Copy link
Contributor

I know I agreed to filter it out, but I found the source of the issue! The snippet itself is sent as a plain text snippet with no placeholder. I think we can just fix on the Roslyn side

@davidwengier
Copy link
Contributor Author

I stand by my previous statement, except replace "editor" with "Roslyn". Looks like this snippet is not supported by Inline Completion (https://github.com/dotnet/roslyn/blob/main/src/LanguageServer/Protocol/Handler/InlineCompletions/InlineCompletionsHandler.cs#L40) so perhaps just shouldn't be showing up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants