Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should DisplayVSMessage condition read from NETCoreAppMaximumVersion instead of UnsupportedTargetFrameworkVersion #44839

Open
ViktorHofer opened this issue Nov 13, 2024 · 0 comments
Assignees
Labels
Area-NetSDK untriaged Request triage from a team member

Comments

@ViktorHofer
Copy link
Member

<DisplayVSMessage Condition="$([MSBuild]::VersionLessThan($(MSBuildVersion), '$(MinimumVisualStudioVersionForUnsupportedTargetFrameworkVersion)')) and '$(BuildingInsideVisualStudio)' == 'true' and '$(_TargetFrameworkVersionWithoutV)' == '$(UnsupportedTargetFrameworkVersion)' and '$([MSBuild]::IsOSPlatform(`Windows`))' == 'true'">true</DisplayVSMessage>

I'm not sure why we need the UnsupportedTargetFrameworkVersion property when we already have NETCoreAppMaximumVersion. The latter defines the maximum .NETCoreApp version that the SDK supports targeting. The former is basically NETCoreAppMaximumVersion+1.

This is now coming up because i.e. in runtime we target net10.0 with a .NET 9 SDK and set NETCoreAppMaximumVersion to 10.0. Now with the additional UnsupportedTargetFrameworkVersion property, we would also need to override that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

2 participants