Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup accessibility text #1911

Open
LuLaValva opened this issue May 24, 2023 · 2 comments
Open

Cleanup accessibility text #1911

LuLaValva opened this issue May 24, 2023 · 2 comments

Comments

@LuLaValva
Copy link
Member

LuLaValva commented May 24, 2023

From discussion with Ian... we should look through all of our components and figure out which ones have English defaults for accessibility text. WAE won't catch issues if there is something there, even if that something is wrong.

EDIT: Goutham and I decided to expand on this ticket for some additional cleanup related to a11y.

List a11y attributes with bad names:

  • button
    • a11yText | aria label for button when bodyState === loading
      • should be a11yLoadingText

List a11y attributes that are missing defaults:

  • button
    • a11yText | aria label for button when bodyState === loading
      • currently empty, should be "Loading"

List a11y attributes that have bad defaults

tbd

List a11y attributes that have bad storybook example text

  • carousel
    • aria-label = "Continious"
      • Should be empty
@LuLaValva LuLaValva self-assigned this May 24, 2023
@agliga agliga assigned saiponnada and unassigned LuLaValva Aug 17, 2023
@agliga agliga added this to eBayUI Aug 17, 2023
@agliga agliga added this to the 12.6.0 milestone Aug 17, 2023
@agliga agliga moved this to Todo in eBayUI Aug 17, 2023
@saiponnada
Copy link
Contributor

For example in carousel - Continuous is hardcoded and used across ebayUI
image

@saiponnada
Copy link
Contributor

Need to identify all the places where this dummy text needs to be removed.

@saiponnada saiponnada changed the title Remove Dummy Text for aria roles when nothing is provided Cleanup accessibility text Sep 6, 2023
@agliga agliga modified the milestones: 12.6.0, 13.1.0 Sep 13, 2023
@agliga agliga modified the milestones: 13.1.0, 13.2.0 Jan 17, 2024
@ArtBlue ArtBlue modified the milestones: 13.2.0, 13.3.0 Feb 16, 2024
@saiponnada saiponnada removed this from the 13.3.0 milestone Mar 19, 2024
@saiponnada saiponnada removed their assignment Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

5 participants