Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Buttons to Design Spec #2421

Open
1 task done
namtheho opened this issue Aug 14, 2024 · 2 comments
Open
1 task done

Update Buttons to Design Spec #2421

namtheho opened this issue Aug 14, 2024 · 2 comments

Comments

@namtheho
Copy link

namtheho commented Aug 14, 2024

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

The contrast on the primary button focus in web appears to be very subtle and potentially not up to accessibility (A11Y) standards.

Screen Recording of Issue

Additional context via slack conversation

Expected behavior

Design specifications need to be reviewed and updated to ensure consistency and adherence to accessibility standards.

Specs can be found here — https://playbook.ebaydesign.tech/design-system/components/cta-button/?tab=accessibility

image

Skin version

Current

Device/OS/Browser info

No response

Steps to reproduce

1.
2.
3.
...

Relevant code block

No response

Additional context

No response

@agliga
Copy link
Contributor

agliga commented Aug 23, 2024

Keep browser defaults as much as we can
Just might need to add an outline offset.

@saiponnada saiponnada removed this from the 18.3.0 milestone Sep 11, 2024
@saiponnada saiponnada removed this from eBayUI Sep 11, 2024
@saiponnada saiponnada removed their assignment Sep 11, 2024
@agliga agliga closed this as completed Oct 28, 2024
@agliga agliga reopened this Oct 28, 2024
@agliga agliga added this to eBayUI Oct 30, 2024
@agliga agliga added this to the 18.5.0 milestone Oct 30, 2024
@agliga
Copy link
Contributor

agliga commented Oct 30, 2024

Will wait for design to give us global focus specs, so we can do this for all elements

Will close this issue and reopen a new issue.

@agliga agliga removed this from the 18.5.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants