Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebay-filter-menu: search field header #2451

Open
3 tasks
randybascue opened this issue Sep 23, 2024 · 9 comments
Open
3 tasks

ebay-filter-menu: search field header #2451

randybascue opened this issue Sep 23, 2024 · 9 comments

Comments

@randybascue
Copy link

randybascue commented Sep 23, 2024

Problem

We have received requests across multiple teams for a search field to be available as a header option in menus. The search field is preferred when there is a large amount of values in a menu and the list is being launched from a filter menu.

Solution

Add support for a search field in a header of the menu component.

Acceptance criteria

  • A property is available to reveal a search field at the top of the menu.
  • The search field narrows the list as characters are entered.
  • The search field can be cleared quickly with a trailing clear button.
  • The search field matches the design specifications.

Screenshots

Figma link

Engineering pre-requisites

  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
@randybascue
Copy link
Author

This is a ticket for discussion. Still needs to go through checks. Will discuss on Wednesday

@agliga agliga added this to eBayUI Sep 27, 2024
@ArtBlue ArtBlue changed the title ebay-menu: search field header ebay-filter-menu: search field header Oct 3, 2024
@agliga agliga added this to the 18.5.0 milestone Oct 30, 2024
@agliga agliga self-assigned this Oct 30, 2024
@agliga
Copy link
Contributor

agliga commented Oct 30, 2024

Should be good to implement, just need final specs from design.

@namtheho
Copy link

namtheho commented Oct 30, 2024

This is not applicable to us

Here are some additional context for the requirements pulled from this doc: https://docs.google.com/document/d/1_4pWNKJ-ZnJT6tRht7zibtlukhpzRJSi894-r4-bGUg/edit?tab=t.0

  • Multi-Brand selector - functional requirements (designs here)
  • Sort brands alphabetically
  • Allow search for brands
  • Once a brand is being typed, automatically start filtering for brands with each keystroke
  • Only update dashboard content when apply button is clicked (i.e. selected brands do not impact the page data until the apply button is clicked)
  • If the user has access to only one brand, disable drop-down
  • Allow multi-select (up to 40)
  • Differentiate between parent and children brands (i.e. hyphenation Parent Brand - child brand)
  • Only children should be selectable, but once parent is selected, all children are selected. If Parent is unselected, all children are selected.
  • Only show brands that are available in the selected marketplace
  • Error state when no brand is found.

@randybascue
Copy link
Author

image

@randybascue
Copy link
Author

CleanShot.2024-11-04.at.10.39.50.mp4

@randybascue
Copy link
Author

@agliga @ArtBlue added visual examples, an animated example, and a link to the Playbook page with a section added for the search behavior

@randybascue
Copy link
Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pull request
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants