Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update modules' Design System component mapping metadata #2486

Open
6 tasks
cordeliadillon opened this issue Nov 5, 2024 · 1 comment
Open
6 tasks

Comments

@cordeliadillon
Copy link
Contributor

Description

Update the component mapping metadata at the bottom of the following skin modules' .marko files to ensure that we are passing accurate information about component availability to our Component Status API. This API powers the cross-platform availability tables in our broader design system documentation.

Requested changes:

skin module ds-component mapping comments
button cta-button change from generic "button"
calendar date-picker
chart-legend graph
combobox combobox
confirm-dialog dialog
cta-button cta-button
field input
floating-label input
inline-notice inline-notice change from generic "alert-notice"
lightbox-dialog dialog remove "bottom-sheet"
link-fake link-button
page-notice page-notice change from generic "alert-notice"
section-notice section-notice change from generic "alert-notice"
select select change from "dropdown"
textbox add "password" to list of mappings

Also check DS version numbers of the following modules as they seem quite different from what's in our design system.

  • alert-dialog
  • confirm-dialog
  • cta-button
  • icon-button
  • education-notice

Screenshots

No response

Figma link

No response

Engineering pre-requisites

  • Successful design review with Design System Team.
  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
  • Successful accessibility review with Core A11Y Team.
  • Successful frontend review with eBayUI Team.
@LuLaValva
Copy link
Member

Skin actually splits date-picker into two different components; calendar and date-textbox. I see you have multiple skin modules mapped to input, can you do the same for date-picker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants