You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When a data grid is rendered within an EuiModal, enabling draggable column headers through canDragAndDropColumns causes the header actions to stop working. The popover shows as expected, but attempting to click an action causes the popover to be hidden on mouse down and the action not to run.
Impact and severity
The new draggable column headers are awesome and we're updating Discover to use them (elastic/kibana#197832), but some of the consumers of our grid render it within modals, so this bug will prevent them from adopting this feature. Currently we've made it opt-in for consumers, but this hurts UX consistency in Kibana, so it would be better if we could enable it everwhere.
Environment and versions
EUI version: 97.3.0
React version: 17.0.2
Kibana version (if applicable): 8.17
Browser: Edge Chromium
Operating System: macOS
To Reproduce
Steps to reproduce the behavior:
Render EuiDataGrid with EuiModal and pass canDragAndDropColumns.
Click on a column header action menu button.
Attempt to click a header action, e.g. "Move left".
The action doesn't run.
Expected behavior
The column header action menu should work when rendered within EuiModal and using canDragAndDropColumns.
@davismcphee Thanks for raising this! 🙏
I can confirm that it's reproducible and it's related to this change here. The condition for the custom "blur" event doesn't always work as expected.
@davismcphee Besides this bug, we we're wondering what's the use case for EuiDataGrid inside modals? Generally we're discouraging complex content inside modals in favor of flyouts instead. (as stated on the docs here).
@mgadewoll Thanks for fixing it! The main use case I'm aware of (and how we caught this) is for Timeline, where a Discover like experience is embedded in a modal across the Security solution. Timeline is maintained by @elastic/security-threat-hunting-investigations, but they use some of our components including the Discover data grid.
Describe the bug
When a data grid is rendered within an
EuiModal
, enabling draggable column headers throughcanDragAndDropColumns
causes the header actions to stop working. The popover shows as expected, but attempting to click an action causes the popover to be hidden on mouse down and the action not to run.Impact and severity
The new draggable column headers are awesome and we're updating Discover to use them (elastic/kibana#197832), but some of the consumers of our grid render it within modals, so this bug will prevent them from adopting this feature. Currently we've made it opt-in for consumers, but this hurts UX consistency in Kibana, so it would be better if we could enable it everwhere.
Environment and versions
To Reproduce
Steps to reproduce the behavior:
EuiDataGrid
withEuiModal
and passcanDragAndDropColumns
.Expected behavior
The column header action menu should work when rendered within
EuiModal
and usingcanDragAndDropColumns
.Minimum reproducible sandbox
https://codesandbox.io/p/sandbox/young-rain-rxkk38
Screenshots
The text was updated successfully, but these errors were encountered: