Mismatched type for fortio response

[Revolyssup]

Title: Mismatched type for fortio response causes failure in interconversion

Description:
The message format in protobuff here

nighthawk/api/client/transform/fortio.proto

Line 31 in f42add9

uint32 RequestedQPS = 3;

mismatches the expected datatype by fortio here https://github.com/fortio/fortio/blob/d2a2d42f4f17df4c09e608353546ebd0d443747d/periodic/periodic.go#L221 on the field RequestedQPS

This is causing Unmarshalling to fail while conversion from one to another.
Reproduction steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Logs:

Include the Nighthawk logs.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Call Stack:

If the Envoy binary is crashing, a call stack is required.
Please refer to the Bazel Stack trace documentation.

[leecalcote]

Thank you for filing this, @Revolyssup

[mum4k]

Thank you for the report @Revolyssup.

Can you help me understand - are you saying that the correct type is int as exported by Nighthawk, but fortio incorrectly takes that in as a string? Or are we saying that fortio is correct and we should adjust the Nighthawk's fortio transform to export QPS as string instead of int?

[leecalcote]

@MUzairS15 will you offer these details? Let's work through this item.

[MUzairS15]

yes, @mum4k
fortio exports QPS as string https://pkg.go.dev/fortio.org/fortio/periodic#RunnerResults.
Another example is RetCodes https://github.com/fortio/fortio/blob/v1.55.0/fhttp/httprunner.go#L37
Fortio expects map[int]int were as nighthawk transforms it as map'[string]int

nighthawk/api/client/transform/fortio.proto

Line 49 in 0fb8286

map<string, uint64> RetCodes = 11;

The Transformation needs to be updated.

[mum4k]

Thank you for explaining that @MUzairS15, given this just needs a modification in the interface between Nighthawk and Fortio, we should be ok to make this change without breaking anyone. I will go ahead and mark this issue as "help wanted", that way anyone with the cycles can pick it up and contribute the fix.