Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

No assertion when toValue or fromValue is of an incompatible type #356

Open
zats opened this issue Mar 17, 2017 · 0 comments
Open

No assertion when toValue or fromValue is of an incompatible type #356

zats opened this issue Mar 17, 2017 · 0 comments

Comments

@zats
Copy link
Contributor

zats commented Mar 17, 2017

I make this mistake very often: when creating animation for kPOPLayerScaleXY I set to and from values to NSNumber not CGSize

It would be great to see an exception or assertion. Currently it just silently fails:

POPSpringAnimation *anim = [POPSpringAnimation animationWithPropertyNamed:kPOPLayerScaleXY];
anim.springBounciness = 4;
anim.springSpeed = 5;
anim.fromValue = @.94; // silently fails, layer never becomes visible
anim.toValue = @1; // same
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant