-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LEARN] features / UI updates V3.0 #449
Comments
cc @ahmadabdolsaheb :) |
Thanks for putting this detailed list together. Here are a few points worth mentioning:
|
Is this just for the new challenges? |
Yes for now, until we redesign the editor for the older curriculum. |
I think it is fine to do on the old and the new challenges as it's basically the same. |
I agree, I think the design is mainly usable for older challenges but there are a few points to keep in mind for the new RWD.
If it is a high priority, I will mock the older RWD. |
I wouldn't say it's high priority as finishing off the current design would take some time but it would be great to have that also. |
awesome, let's get this in and see the feedback. We could redesign the old RWD accordingly. |
@ahmadabdolsaheb In the design link, the dropdown text is just |
So that is an accessibility consideration. Not sure if it applies to mobile. Feel free to look up best practices. |
What exactly should be in the twitter card? |
Good question. This feature needs more research to see what the convention is. We can initially only show the button when the block is completed and share a link to the block with a meaningful predesigned OG image. Ultimately we would need to have a dynamic twitter cards similar to freeCodeCamp/freeCodeCamp#47085 Feel free to post pond this feature until we finalize the functionality on the learn repo. |
For the last action item:
|
Although I am not sure why we would need a toggle at the first place.
|
This looks solid Ahmad. If wee keep the amount of files under four it should be good. |
Design link- https://www.figma.com/file/4XPlUi8QGWsmyV7hA8r86m/learn-mobile
PhoneIDE
Learn
Required before release
Updated tasks
Challenge
Header
Instructions Pane - #481
Hint Pane
Pass Pane
Lower function bar
Superblock
Block pages
This includes minimal viable product and extra's, this may be discussed publicly. Please if I missed something you would like to see add a comment below.
Problems and features found/needed in development
This space will be updated with bugs or UI fixes which we come across while making this component
Features
Bugs and Flutter errors
The text was updated successfully, but these errors were encountered: